Reduce the default verbosity of JS library error messages #8339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Mar 25, 2019
| error('failure to execute js library "' + filename + '": ' + details + '\npreprocessed source (you can run a js engine on this to get a clearer error message sometimes):\n=============\n' + processed + '\n=============\n'); | ||
| error('failure to execute js library "' + filename + '": ' + details); | ||
| if (VERBOSE) | ||
| error('preprocessed source (you can run a js engine on this to get a clearer error message sometimes):\n=============\n' + processed + '\n============='); |
There was a problem hiding this comment.
{, } if if/else bodies are on another line, like here and later down.
Currently the entire library is printed which makes seeing the actual error very difficult. Normally the filename and line number should be sufficient and we can put the rest of it befind VERBOSE=1.
sbc100
force-pushed
the
cleaner_library_error
branch
from
0f477f0
to
b608b9c
Compare
VirtualTim
pushed a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
…-core#8339) Currently the entire library is printed which makes seeing the actual error very difficult. Normally the filename and line number should be sufficient and we can put the rest of it befind VERBOSE=1.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…scripten-core#8339)" This reverts commit 1a22f4c.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…scripten-core#8339)" This reverts commit 1a22f4c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the entire library is printed which makes seeing the
actual error very difficult. Normally the filename and line number
should be sufficient and we can put the rest of it befind VERBOSE=1.